-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github actions 自动发布新版本。 #233
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThe pull request enhances the GitHub Actions workflows by adding a manual trigger for releases and dynamic tag retrieval, updates artifact handling in release jobs, adjusts the trigger for flutter analysis, and standardizes the NDK version in the Android build configuration. Sequence diagram for dynamic release tag retrievalsequenceDiagram
participant U as Actor (Trigger)
participant GH as GitHub Actions
participant GT as "Get Tag Step"
participant CR as "Create Release Step"
participant API as "GitHub Release API"
U->>GH: Trigger release (workflow_dispatch or tag push)
GH->>GT: Execute 'Get release tag' step
alt Workflow Dispatch Trigger
GT-->>GH: Return input tag (from workflow_dispatch)
else Tag Push Trigger
GT-->>GH: Return tag derived from GITHUB_REF
end
GH->>CR: Pass tag to create release
CR->>API: Create release with tag & release notes
API-->>CR: Confirm release created
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rebecca554owen - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a matrix build strategy to avoid repeating the release logic for each platform.
- The
fl-analysis.yaml
workflow is missing a trigger for push events on the main branch.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- name: Get release tag | ||
id: get-tag | ||
shell: bash | ||
run: | | ||
if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then | ||
echo "tag=${{ github.event.inputs.tag }}" >> $GITHUB_OUTPUT | ||
else | ||
echo "tag=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider reducing duplication in the 'Get release tag' step.
The same bash snippet is repeated across multiple jobs. It might be beneficial to extract this logic into a reusable composite action or reference a common script to ease maintenance.
Summary by Sourcery
Enable manual triggering of releases and automatically generate release notes.
New Features:
Enhancements:
CI: