Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2 features in s3 output plugin #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cnhappier
Copy link

  1. make codec configurable
  2. move file to bucket in graceful shutdown

move file to bucket in graceful shutdown
@dmlogs
Copy link

dmlogs commented May 29, 2015

  1. is covered in logstash/outputs/base

  2. I would argue should be a configuration. Forcing a flush may not always be desirable.

@cnhappier
Copy link
Author

according to dmlogs's comment, add move_file_to_bucket flag to disable the move file in shutdown

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@runningman84
Copy link

@cnhappier can you sign the CLA in order to get this integrated?

@cnhappier
Copy link
Author

@karmi @runningman84 I've signed the CLA, how can I continue to merge this?

@chadbean
Copy link
Contributor

@cnhappier looks like there's a merge conflict now. If that gets fixed is this in a good place to merge? This would be very useful. Another thought: what if this was updated to upload all files in the persisted queue to S3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants