Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add _type if ES version < 8 #890

Closed
wants to merge 6 commits into from

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Oct 18, 2019

Resolves #887.

Starting from 8.0.0, Elasticsearch has removed the _type field from its bulk API actions. This PR teaches the Elasticsearch output to only add the _type field to bulk API actions if the Elasticsearch cluster's major version is < 8.

TODO

  • Update tests

@ycombinator ycombinator marked this pull request as ready for review October 18, 2019 15:36
@ycombinator ycombinator removed the request for review from jsvd October 18, 2019 16:21
@ycombinator
Copy link
Contributor Author

Replaced by #892. Thanks @robbavey for taking over this work ❤️!

@ycombinator ycombinator deleted the es8-typeless branch October 22, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES output fails with 400 due to types removal
1 participant