Doctype deprecation #691
Closed
Doctype deprecation #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dedemorton this potentially has a lot of implications for docs on the site. Would you be able to investigate the impact there? |
34 tasks
|
After this is merged we'll need to make sure to update the 6.0.0-rc2 lockfile with the latest version. |
|
This is kind of tricky because I know there is urgency to land this, but please pause and evaluate how we can make this work and not annoy users who are using LS 6 to talk to ES 5 clusters. |
|
@jordansissel that's a good point. I'm open to not deprecating document type given that point. @ph WDYT? |
|
LGTM with your revised |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Sep 29, 2017
elasticsearch-bot
pushed a commit
that referenced
this pull request
Sep 29, 2017
elasticsearch-bot
pushed a commit
that referenced
this pull request
Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #669 by deprecating the
doc_typeoption and moving the default type name fromlogstodoc.We want to get this in before 6.0.0 GA otherwise it will have to wait for LS 7.0.0
The really nice thing about moving from
logstodoc, aside from beats integration, is that it better reflects the generic nature of Logstash.We will also need to add this to breaking changes in Logstash core.