Add ssl_enabled option #44
Conversation
| @@ -75,6 +75,9 @@ def self.included(base) | |||
| # See https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.html#setValidateAfterInactivity(int)[these docs for more info] | |||
| base.config :validate_after_inactivity, :validate => :number, :default => 200 | |||
|
|
|||
| # Enable/disable the SSL configurations | |||
| base.config :ssl_enabled, :validate => :boolean, :default => true | |||
There was a problem hiding this comment.
es-output and es-input have ssl_enabled with no default value. It bases on the host prefix, https or http, to enable ssl feature, which is kind of setting to auto.
Would default to true changes the behaviour of existing plugins?
Could the mixin default to auto and preserve the current smart ssl feature?
There was a problem hiding this comment.
Hi @kaisecheng! This mixin already assumes ssl_enabled => true, adding all the configured ssl_* settings to the manticore's client, without giving users an option to disable them (other than comment out the SSL configuration). That said, it shouldn't change any existing behaviour.
Currently, this mixin is being used by the HTTP filter, output and poller plugins, and won't affect ES and other plugins that does not use it under the hood.
The ideal behaviour of the ssl_enabled flag is under discussing, there are different behaviours for this option depending on the plugin, and that will be standardised on the second phase of the SSL Standardisation project. Adding this option only makes it compliant with the defined common settings.
Could the mixin default to auto and preserve the current smart ssl feature?
For the existing plugin using this mixin, no. The client itself does not know how the plugin will use it, it doesn't know the URLs it will request, for example. it only adds the configs and builds the client, hading it over to the plugins to execute the requests and add any other smart features.
There was a problem hiding this comment.
sorry, I mixed the http plugin with es plugin 🤦 The settings make perfect sense
Added a new
ssl_enabledsetting for enabling/disabling the other SSL configurations, so plugins using this mixing will be compliant with the Logstash SSL standards.Closes: #45