Update sequel version to >= 5.74.0 #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmocosta
force-pushed
the
updrage-sequel-version
branch
from
0249acd to
f1bc24f
Compare
edmocosta
changed the title
edmocosta
changed the title
jsvd
reviewed
Jan 31, 2024
logstash-integration-jdbc.gemspec
Outdated
Comment on lines
32
to
34
| # Pinned sequel version to >= 5.75.0 as it fixes the generic jdbc adapter to properly | ||
| # handle disconnection errors, and avoid stale connections in the pool. | ||
| s.add_runtime_dependency 'sequel', '>= 5.75.0' |
There was a problem hiding this comment.
Suggested change
| # Pinned sequel version to >= 5.75.0 as it fixes the generic jdbc adapter to properly | |
| # handle disconnection errors, and avoid stale connections in the pool. | |
| s.add_runtime_dependency 'sequel', '>= 5.75.0' | |
| # Pinned sequel version to >= 5.74.0 as it fixes the generic jdbc adapter to properly | |
| # handle disconnection errors, and avoid stale connections in the pool. | |
| s.add_runtime_dependency 'sequel', '>= 5.74.0' |
Given the fix was introduced with jeremyevans/sequel@813db79 and shipped with 5.74.0, maybe we can change this to 5.74.0 instead?
There was a problem hiding this comment.
Agreed, it makes sense! Thanks!
edmocosta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
sequelgem version to >= 5.74.0Closes: #152