-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use jruby-stdin-channel if possible for an interruptible stdin #3
use jruby-stdin-channel if possible for an interruptible stdin #3
Conversation
@colinsurprenant Can you rebase it off master? The specific stdin channel handling look good but I haven't tested it. |
fb5ee85
to
627601e
Compare
@ph rebased and bumped version. since specs are rather basic we should either have integration tests for both Java 7 + Java 8 or do manual tests on both JVM. |
@colinsurprenant I will do a small manual testing for that. This only work on java 8? We can probably drop the compatibility for java 7 in this PR and only merge it to the master branch? |
LGTM Tested with core with JDK7 and JDK8
|
@ph we should keep the normal stdin fallback because the |
@colinsurprenant Make sense. |
LGTM |
627601e
to
97ab2b1
Compare
bumped to v2.1.0
97ab2b1
to
d33b054
Compare
bumped version and merged in master |
solves to uninterruptible stdin when running on Java 8.
if running on Java 8, doing ^C will correctly terminate logstash unlike before where you had to type an extra character to unblock stdin.
related to elastic/logstash#1769
I only tested on OSX with Java 7 and 8.
I did not measure any noticeable performance difference using
jruby-stdin-channel
or not.