Fix ECS test failure cases. #23
Conversation
spec/inputs/stdin_spec.rb
Outdated
|
|
||
| subject { LogStash::Inputs::Stdin.new } | ||
| require "logstash/codecs/json" | ||
| subject { LogStash::Inputs::Stdin.new("codec" => LogStash::Codecs::JSON.new) } |
There was a problem hiding this comment.
review note why codec change needs: the root cause for test failure is, we ca calling directly process() method of the plugin which \n always stay. For the real scenarios, StdinChannel::Reader.new or standard $stdin escapes the new line. So, in the test cases, changed plugin default Line (since its delimiter \n and removes when ECS enabled) codec to JSON codec to avoid the new line (\n).
There was a problem hiding this comment.
Instead of changing the codecs, maybe we can add strip to the validation
expect( event.get('event') ).to eql 'original' => stdin_data.strip
just like the "sets hostname" test case
There was a problem hiding this comment.
@mashhurs Thanks for improving the test cases. I have one suggestion to make the test case aligned with the others.
spec/inputs/stdin_spec.rb
Outdated
|
|
||
| subject { LogStash::Inputs::Stdin.new } | ||
| require "logstash/codecs/json" | ||
| subject { LogStash::Inputs::Stdin.new("codec" => LogStash::Codecs::JSON.new) } |
There was a problem hiding this comment.
Instead of changing the codecs, maybe we can add strip to the validation
expect( event.get('event') ).to eql 'original' => stdin_data.strip
just like the "sets hostname" test case
@kaisecheng if we align on default and I have applied it. Details: we receive the data with |
Description
This change fixes the test case failure, example failure.
Details: the root cause for test failure is, we ca calling directly
process()method of the plugin. For the real scenarios,StdinChannel::Reader.newor standard$stdinescapes the new line. So, in the test cases, changed plugin defaultLinecodec toJSONcodec to avoid the new line (\n).