Add tzinfo-data and fix tests #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous attempt to use stub_const did not "unset" between runs. It is simpler to hard-code a timezone for all tests, to guarantee that there are no ambiguities. Because SQL timestamps do not allow for timezone or offset data, this should not be a limiting factor for the tests.
| # This is a necessary change test-wide to guarantee that no local timezone | ||
| # is picked up. It could be arbitrarily set to any timezone, but then the test | ||
| # would have to compensate differently. That's why UTC is chosen. | ||
| ENV["TZ"] = "Etc/UTC" |
There was a problem hiding this comment.
I would bring back stub_const and place it in the before :each block here:
https://github.com/logstash-plugins/logstash-input-jdbc/pull/97/files#diff-9c9936a0fd95805a5aa45981f93241c0L23
There was a problem hiding this comment.
I overlooked that in the previous PR
|
LGTM |
|
Aaron Mildenstein merged this into the following branches!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt to use stub_const did not "unset" between runs.
It is simpler to hard-code a timezone for all tests, to guarantee
that there are no ambiguities.
Because SQL timestamps do not allow for timezone or offset data, this
should not be a limiting factor for the tests.