Set application timezone for zoneless datestamps #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untergeek
force-pushed
the
fix/89
branch
3 times, most recently
from
e1807c0 to
8e9ce6d
Compare
| @@ -65,6 +67,14 @@ def setup_jdbc_config | |||
| # The amount of seconds to wait to acquire a connection before raising a PoolTimeoutError (default 5) | |||
| config :jdbc_pool_timeout, :validate => :number, :default => 5 | |||
|
|
|||
| # Timezone conversion. | |||
There was a problem hiding this comment.
these docs do a great job describing the behaviors around timezones, but it would be great to be clearer around what setting this parameter will achieve, instead of just the differing behaviors of timezone management by the plugin
Fortunately, the Sequel gem already had the necessary functionality. However, it turns out that Sequel _can_ do named timezones, but when you do the date comes back as a DateTime object instead. As a result, this should only use named_timezone support if defined, which should save cycles for those who already have their date fields in UTC, rather than punishing every user. Use string date to test timezone conversion to guarantee similarity to the issue case
|
LGTM |
|
Aaron Mildenstein merged this into the following branches!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fortunately, the Sequel gem already had the necessary functionality.