Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jdbc_paging_enabled config flag not being passed through #361

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

bmax
Copy link
Contributor

@bmax bmax commented Nov 6, 2019

fixes #360

Not a ruby developer by trade so having trouble making the test better.

First PR. I signed CLA after I made this.
cc @guyboertje

@bmax
Copy link
Contributor Author

bmax commented Nov 21, 2019

@robbavey Any help?

Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmax Thanks for the contribution! I'll merge this shortly, and follow up with a changelog entry and version bump

@robbavey robbavey merged commit 48ba108 into logstash-plugins:master Nov 22, 2019
@robbavey
Copy link
Contributor

@bmax - This has been merged and included in the latest 4.3.19 release of the JDBC input. Thanks again for your contribution!

@bmax
Copy link
Contributor Author

bmax commented Nov 25, 2019

woohoo @robbavey! Super excited, thanks. How does the default version that gets included with Logstash's Dockerfile get updated?

@robbavey
Copy link
Contributor

@bmax Logstash (including the docker image) is released at the same time as the rest of the Elastic stack, and this change will be included in a future release.
However, we don't tend to give out dates and the exact release version that changes will be released in ahead of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paging bug: JDBC_PAGING_ENABLED and JDBC_PAGE_SIZE degraded after version 4.3.14
2 participants