Clarify use of use_column_value #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenzone
changed the title
jakelandis
reviewed
Mar 29, 2018
docs/index.asciidoc
Outdated
|
|
||
| * Value type is <<string,string>> | ||
| * There is no default value for this setting. | ||
|
|
||
| If tracking column value rather than timestamp, the column whose value is to be tracked | ||
| The column whose value is to be tracked (if tracking column value rather than the last time the query was run) |
There was a problem hiding this comment.
How about "The column whose value is to be tracked if use_column_value is set to true" ?
There was a problem hiding this comment.
Much better. Thanks for that. Changed.
|
@karenzone - changes look good. one minor suggestion. For phase 2, I will log a proposal issue. I think we can get rid of one (maybe two of these settings). |
|
Logged #279 for phase 2 |
…e in record_last_run entry clickable. Reword description
|
LGTM |
dedemorton
approved these changes
Apr 4, 2018
|
Yes, I tested without issue |
|
karen.metts merged this into the following branches!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify use of use_column_value.
Make last_run_metadata_path reference in record_last_run entry clickable.
Phase 1 fix for #273.
Phase 2 will involve reworking the topic