Allow tracking by column number, not just time #108
Conversation
|
we should not remove the tracking of |
|
You think so? I'm guess that's a possibility, but it seems like a rather uncommon one. |
| @logger.debug? and @logger.debug("Executing JDBC query", :statement => statement, :parameters => parameters, :count => query.count) | ||
|
|
||
| if @jdbc_paging_enabled | ||
| query.each_page(@jdbc_page_size) do |paged_dataset| | ||
| paged_dataset.each do |row| | ||
| sql_last_value = row[@tracking_column.to_sym] if @use_column_value |
There was a problem hiding this comment.
should we log a warning if @tracking_column is not present in the result set?
There was a problem hiding this comment.
That's probably a good idea.
| @@ -175,17 +179,20 @@ def execute_statement(statement, parameters) | |||
| begin | |||
| parameters = symbolized_params(parameters) | |||
| query = @database[statement, parameters] | |||
| sql_last_start = Time.now.utc | |||
| sql_last_value = @use_column_value ? @sql_last_value : Time.now.utc | |||
| @warning_sent = false | |||
There was a problem hiding this comment.
since we may introduce additional warnings, maybe this should be named something specific to the column retrieval?
|
left a few comments, looks good. |
Test for tracking_column and warn user once per query if it's not there. Add a test to verify this is working properly closes logstash-plugins#57
|
Aaron Mildenstein merged this into the following branches!
|
|
When using a tracking column, if the statement retrieves multiple rows, which value will be saved? The maximum value? Or the value from the "last" row in the result set? |
|
@leifurhauks as per the current implementation[1], it is the value from the "last" row in the result-set. |
closes #57