Updated Gradle and Google Cloud Storage client library #20

andsel · 2022-08-23T14:19:50Z

Release notes

Updates Cloud Storage dependencies forcing this plugin to be compatible only with Logstash >= 8.3.0

What does this PR do?

Update Google Cloud Storage client (and transitive dependencies) from 1.62.0 to 1.118.1

Imposes Logstash 8.3.0 runtime requirement due to alignment on jackson-core 2.13.3

Why is it important/What is the impact to the user?

Keeps libraries updated
Removes 7.x branch testing from Travis matrix test

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files (and/or docker env variables)
I have added tests that prove my fix is effective or that my feature works

Author's Checklist

[ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Closes elastic/logstash#14474

…atibility

robbavey · 2022-09-21T16:25:43Z

@andsel I was unable to test this on my development laptop, due to the following error:

[FATAL] 2022-09-21 12:17:46.872 [main] Logstash - Logstash stopped processing because of an error: (VersionConflict) Bundler could not find compatible versions for gem "mimemagic":
  In Gemfile:
    logstash-input-google_cloud_storage was resolved to 0.11.1, which depends on
      mimemagic (>= 0.3.3)

Could not find gem 'mimemagic (>= 0.3.3)', which is required by gem 'logstash-input-google_cloud_storage', in any of the sources.
org.jruby.exceptions.StandardError: (VersionConflict) Bundler could not find compatible versions for gem "mimemagic":
  In Gemfile:
    logstash-input-google_cloud_storage was resolved to 0.11.1, which depends on
      mimemagic (>= 0.3.3)

Could not find gem 'mimemagic (>= 0.3.3)', which is required by gem 'logstash-input-google_cloud_storage', in any of the sources.

andsel · 2022-09-22T08:26:21Z

@robbavey how did you tested this?
Did you used the following definition in your Gemfile?

gem "logstash-input-google_cloud_storage", :path => "/path_to/logstash-input-google_cloud_storage"

Or did you generated the gem and installed on Logstash?

plugin> gem build logstash-input-google_cloud_storage.gemspec

logstash> bin/logstash-plugin install --local /path_to/logstash-input-google_cloud_storage/logstash-input-google_cloud_storage-0.11.1-java.gem

…undled in the gem

robbavey · 2022-09-21T15:51:30Z

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.11.1


Let's make this a minor update.

robbavey · 2022-09-21T15:52:02Z

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.11.1
+ - Updated Google Cloud Storage client library [#20](https://github.com/logstash-plugins/logstash-input-google_cloud_storage/pull/20)


We should explicitly state the limitation on logstash version imposed by this new version in the changelog

robbavey · 2022-09-23T14:52:48Z

I added the definition in my Gemfile. Let me try the other

robbavey · 2022-09-23T15:00:08Z

@andsel Same result, this time when installing the plugin

Using system java: /usr/bin/java
Validating /Users/robbavey/code/plugins/logstash-input-google_cloud_storage/logstash-input-google_cloud_storage-0.11.1-java.gem
Installing logstash-input-google_cloud_storage
Plugin version conflict, aborting
ERROR: Installation Aborted, message: Bundler could not find compatible versions for gem "mimemagic":
  In Gemfile:
    logstash-input-google_cloud_storage (= 0.11.1) was resolved to 0.11.1, which depends on
      mimemagic (>= 0.3.3)

Could not find gem 'mimemagic (>= 0.3.3)', which is required by gem 'logstash-input-google_cloud_storage (= 0.11.1)', in any of the sources or in gems cached in vendor/cache.

andsel · 2022-09-26T14:04:31Z

I was able to reproduce the same error on a clean Ubuntu 22.04.
Once I installed by hand the mimemagic gem into Logstash with:

bin/ruby -S gem install mimemagic -v '>= 0.3.7'

then, I was able to install the plugin with:

bin/logstash-plugin install --local /path_to/logstash-input-google_cloud_storage-0.12.0-java.gem

The same problem happens also on main branch, so it shouldn't be related to this PR.

andsel · 2022-09-26T16:14:13Z

docs/index.asciidoc

+[NOTE]
+================================================================================
+When installing this plugin you could receive an error message about the
+impossibility to find compatible versions for gem "mimemagic".
+This is error could be circumvented by installing the required dependency directly into
+the Logstash Ruby gem's cache.
+
+This could be done going into Logstash installation folder and using the bundled Ruby gems instance:
+
+[source,bash]
+----------------------------------
+bin/ruby -S gem install mimemagic -v '>= 0.3.7'
+----------------------------------
+
+================================================================================
+


Hi @karenzone , I've added this note to describe how to avoid an installation problem. Would be great if you could review it, or ping me if you need more context on the problem we are facing.

@andsel I would do something like this:

Attempting to install this plugin may result in an error about "<post here a sample error that you actually get from installation". If this error occurs, you can fix it by manually by installing the "mime magic" dependency directly into the Logstash Ruby Gem's cache (<provide a link here to where that would be, or the location.). This could be done using the bundled Ruby gems instance inside the Logstash installation folder (< provide references, e.g. a link that shows where things are installed based on the installation method>)

That's a good idea, I rephrased it in ~~64647d0~~ 5c1a507

robbavey

LGTM - over to @karenzone for final approval

roaksoax · 2022-09-27T17:31:37Z

docs/index.asciidoc

+[NOTE]
+================================================================================
+When installing this plugin you could receive an error message about the
+impossibility to find compatible versions for gem "mimemagic".
+This is error could be circumvented by installing the required dependency directly into
+the Logstash Ruby gem's cache.
+
+This could be done going into Logstash installation folder and using the bundled Ruby gems instance:
+
+[source,bash]
+----------------------------------
+bin/ruby -S gem install mimemagic -v '>= 0.3.7'
+----------------------------------
+
+================================================================================
+


@andsel I would do something like this:

Attempting to install this plugin may result in an error about "<post here a sample error that you actually get from installation". If this error occurs, you can fix it by manually by installing the "mime magic" dependency directly into the Logstash Ruby Gem's cache (<provide a link here to where that would be, or the location.). This could be done using the bundled Ruby gems instance inside the Logstash installation folder (< provide references, e.g. a link that shows where things are installed based on the installation method>)

roaksoax

couple suggestions, otherwise looks good to me

andsel added 5 commits August 23, 2022 16:17

Updated Gradle and Google Cloud Storage client library

64647d0

Bumped version 0.11.1

e341a8c

Updated 'jar-dependencies' dependency

01d2142

Added missed dep google-http-client-gson:1.39.2

88819d9

Imposed strong requirement on Logstash 8.3.0 due to jackson-core comp…

8449dba

…atibility

andsel mentioned this pull request Aug 25, 2022

[Meta] Logstash Update Gradle version and dependencies for Google plugins elastic/logstash#14474

Closed

5 tasks

andsel added 2 commits September 15, 2022 15:11

Explicitly requires all transitive runtime dependencies

5c795f4

Minor, removed duplication

d1d9fd4

andsel self-assigned this Sep 20, 2022

andsel requested a review from robbavey September 20, 2022 08:14

Fixed filename, else gem installation would fail if the file is not b…

b21037b

…undled in the gem

robbavey reviewed Sep 23, 2022

View reviewed changes

andsel added 2 commits September 23, 2022 17:36

Bumped the minor 0.12.0

2141120

Required first non yanked mimemagic

90550ba

Added note to clarify how to install the transient mimemagic gem

1c746c6

andsel commented Sep 26, 2022

View reviewed changes

Completed the installation note

324bcfc

andsel requested review from karenzone and robbavey September 26, 2022 16:16

robbavey approved these changes Sep 26, 2022

View reviewed changes

andsel requested review from roaksoax and removed request for karenzone September 27, 2022 16:19

roaksoax suggested changes Sep 27, 2022

View reviewed changes

Rephrased the note about throubleshooting the mimemagic dependency

5c1a507

andsel requested a review from roaksoax September 28, 2022 06:59

Update index.asciidoc

60d1ea4

roaksoax approved these changes Oct 3, 2022

View reviewed changes

andsel merged commit ba639d8 into logstash-plugins:main Oct 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated Gradle and Google Cloud Storage client library #20

Updated Gradle and Google Cloud Storage client library #20

andsel commented Aug 23, 2022 •

edited by roaksoax

Loading

robbavey commented Sep 21, 2022

andsel commented Sep 22, 2022

robbavey Sep 21, 2022

robbavey Sep 21, 2022

robbavey commented Sep 23, 2022

robbavey commented Sep 23, 2022

andsel commented Sep 26, 2022

andsel Sep 26, 2022

roaksoax Sep 27, 2022 •

edited

Loading

andsel Sep 28, 2022 •

edited

Loading

robbavey left a comment

roaksoax Sep 27, 2022 •

edited

Loading

roaksoax left a comment

		@@ -1,3 +1,6 @@
		## 0.11.1
		- Updated Google Cloud Storage client library [#20](https://github.com/logstash-plugins/logstash-input-google_cloud_storage/pull/20)

Updated Gradle and Google Cloud Storage client library #20

Updated Gradle and Google Cloud Storage client library #20

Conversation

andsel commented Aug 23, 2022 • edited by roaksoax Loading

Release notes

What does this PR do?

Why is it important/What is the impact to the user?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

robbavey commented Sep 21, 2022

andsel commented Sep 22, 2022

robbavey Sep 21, 2022

Choose a reason for hiding this comment

robbavey Sep 21, 2022

Choose a reason for hiding this comment

robbavey commented Sep 23, 2022

robbavey commented Sep 23, 2022

andsel commented Sep 26, 2022

andsel Sep 26, 2022

Choose a reason for hiding this comment

roaksoax Sep 27, 2022 • edited Loading

Choose a reason for hiding this comment

andsel Sep 28, 2022 • edited Loading

Choose a reason for hiding this comment

robbavey left a comment

Choose a reason for hiding this comment

roaksoax Sep 27, 2022 • edited Loading

Choose a reason for hiding this comment

roaksoax left a comment

Choose a reason for hiding this comment

andsel commented Aug 23, 2022 •

edited by roaksoax

Loading

roaksoax Sep 27, 2022 •

edited

Loading

andsel Sep 28, 2022 •

edited

Loading

roaksoax Sep 27, 2022 •

edited

Loading