Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in documentation #235

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Typo in documentation #235

merged 2 commits into from
Apr 1, 2020

Conversation

kristoffeys
Copy link
Contributor

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@robbavey robbavey requested a review from karenzone March 19, 2019 22:16
@karenzone
Copy link
Contributor

Hi @kristoffeys Thanks for helping us improve our documentation. Will you please sign the CLA so that I can take a look at your change?

@kristoffeys
Copy link
Contributor Author

I have signed the agreement

@kares
Copy link
Contributor

kares commented Mar 22, 2020

@kristoffeys CLA check isn't passing ... could you double check pls (otherwise this will get closed)?

@kristoffeys
Copy link
Contributor Author

I've tried again. Should be good now I think?

@karenzone
Copy link
Contributor

Thanks! CLA check looks good. I'll take a look now.

@karenzone karenzone added the docs label Mar 30, 2020
karenzone
karenzone approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds cleanly and looks good to me. Thanks for helping us make our docs better, @kristoffeys. We appreciate your contribution.

Congrats on being a first-time contributor. I hope we'll see you again. <3

@karenzone karenzone merged commit 5cd1171 into logstash-plugins:master Apr 1, 2020
@karenzone karenzone mentioned this pull request Apr 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenzone karenzone karenzone approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristoffeys @karenzone @kares