Doc: Clarify behavior for concatenate_sources option #60
Conversation
|
@kaisecheng Here's a first draft. I look forward to discussing with you and refining the content. |
There was a problem hiding this comment.
👍 @karenzone overall looks good. I believe user will feel much better with the example you give. I provide the updated fingerprints output in case of users really try it and find different output
docs/index.asciidoc
Outdated
| **Example: `concatenate_sources`=false** | ||
|
|
||
| This example produces a single "fingerprint" of | ||
| "6b6390a4416131f82b6ffb509f6e779e5dd9630f". The fingerprint is computed from "birthday" |
There was a problem hiding this comment.
I like the format of multiple fingerprints that you give an example of config and an example of output.
How about making them consistent? Instead of saying This example produces a single "fingerprint" of "6b6390a4416131f82b6ffb509f6e779e5dd9630f", gives
[source,ruby]
"fingerprint" => "6b6390a4416131f82b6ffb509f6e779e5dd9630f"
| [0] "fdfeb16f096983ada02db49d46a8154475d700ae", | ||
| [1] "a85ed0f0a425b690a75fcbab6c256837bac04dad", | ||
| [2] "6b6390a4416131f82b6ffb509f6e779e5dd9630f" | ||
| ], |
There was a problem hiding this comment.
I use Logstash to generate a real output of ["big brother", "little sister", "little brother"]
[0] "8a8a9323677f4095fcf0c8c30b091a0133b00641",
[1] "2ce11b313402e0e9884e094409f8d9fcf01337c2",
[2] "adc0b90f9391a82098c7b99e66a816e9619ad0a7"
Co-authored-by: kaisecheng <[email protected]>
|
@kaisecheng Will you please take a quick look to be sure that I interpreted your review comments correctly? The info and examples you provided were very helpful, and I gave you an authoring credit. :-) |
|
@karenzone the examples look good 💯 thanks for the credit ❤️ |
|
Published at v3.2.3: https://rubygems.org/gems/logstash-filter-fingerprint/versions/3.2.3 |
Related: #59