added support for 128bit murmur variant #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisecheng
requested changes
May 14, 2021
There was a problem hiding this comment.
Hi @mbarretta sorry for the delay and thanks for submitting the PR. Overall looks good. Could you add one test case like murmur3, update the plugin version here and update the changelog ?
Once they are addressed, I can merge it
kaisecheng
added a commit
that referenced
this pull request
May 3, 2022
* added support for 128bit murmur variant * As #42 has not been updated in several years, this commit implements 128-bit murmur3 support and handles the base64 encoding flag correctly as well Co-authored-by: Mike Barretta <[email protected]> Co-authored-by: Seth Grover <[email protected]> Co-authored-by: kaisecheng <[email protected]>
|
resolved in #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would address part of #32