[WIP] Encoder drop additional fields #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/logstash-codec-protobuf into encoder_drop_additional_fields
IngaFeick
changed the title
|
I'm setting this to WIP because we have discovered an NPE when using this in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new config option to automatically discard event fields which are not in the protobuf definition. In the current version 1.2.4 an event with additional fields will be discarded and an error will be logged. This PR adds the option
pb3_encoder_drop_unknown_fields. When activated (default) it will remove incorrect fields from the event before attempting the encoding.