add ECS support #36
Merged
add ECS support #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add decoded message to [event][original]
kares
approved these changes
Jul 20, 2021
lib/logstash/codecs/avro.rb
Outdated
| require 'logstash/plugin_mixins/ecs_compatibility_support/target_check' | ||
| require 'logstash/plugin_mixins/validator_support/field_reference_validation_adapter' | ||
| require 'logstash/plugin_mixins/event_support/event_factory_adapter' | ||
| require 'logstash/plugin_mixins/event_support/from_json_helper' |
There was a problem hiding this comment.
✂️ we do need the require 'logstash/plugin_mixins/event_support/from_json_helper'
11 tasks
karenzone
reviewed
Jul 22, 2021
|
|
||
| Define the target field for placing the row values. If this setting is not | ||
| set, the Avro data will be stored at the root (top level) of the event. | ||
|
|
There was a problem hiding this comment.
Should we include this note from the commented code?
Note that the target is only relevant when decoding data into a new event.
There was a problem hiding this comment.
this is important. many thanks
docs/index.asciidoc
Outdated
| Define the target field for placing the row values. If this setting is not | ||
| set, the Avro data will be stored at the root (top level) of the event. | ||
|
|
||
| For example, if you want data to be put under the `document` field: |
There was a problem hiding this comment.
Suggested change
| For example, if you want data to be put under the `document` field: | |
| *Example* | |
| In this configuration, data will be placed under the `document` field. |
docs/index.asciidoc
Outdated
| } | ||
| } | ||
| } | ||
| ---------------------------------- |
There was a problem hiding this comment.
Suggested change
| ---------------------------------- | |
| ---------------------------------- | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECS support add
targetand[event][original]Fixed: #34