-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add option to encode as binary RubyString instead of base64 #30
[WIP] Add option to encode as binary RubyString instead of base64 #30
Conversation
@original-brownbear good job! I'm seeing consistent messages during the json / avro / kafka route. |
@rubyan nice, will see to it that this gets fixed up (need to improve the docs now) and merged + published shortly then :) |
Hello, why did I use your file or not? I am looking forward to your reply. |
@andrewvc assigning you here, just because I need some feedback from you on this (after the holidays). This is done already, but we need to think about the BwC and documentation required for this change. Will add details soon. |
Any update on a possible merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is good, but this needs tests. Can you add some simple ones here for this @original-brownbear ?
@original-brownbear any chance to get this merged soonish? |
Can someone merge this? We need this asap. |
@jsvd FYI :) |
@original-brownbear The tests are all good, there are no conflicts, can you merge this? |
@jsvd pong :) |
Can you please finalize this merge? Thank you! |
I have a customer waiting for this to merge. Can we get a timing on the release for this? |
Use setting
encode_as_base64 => false
to test :)