Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add option to encode as binary RubyString instead of base64 #30

Conversation

original-brownbear
Copy link
Contributor

Use setting encode_as_base64 => false to test :)

@johanvanderkuijl
Copy link

@original-brownbear good job! I'm seeing consistent messages during the json / avro / kafka route.

@original-brownbear
Copy link
Contributor Author

@rubyan nice, will see to it that this gets fixed up (need to improve the docs now) and merged + published shortly then :)

@haoyu0624
Copy link

Hello, why did I use your file or not? I am looking forward to your reply.
This is an error message
Exception in thread "main" org.apache.avro.AvroRuntimeException: Malformed data. Length is negative: -1552376

@original-brownbear
Copy link
Contributor Author

@andrewvc assigning you here, just because I need some feedback from you on this (after the holidays). This is done already, but we need to think about the BwC and documentation required for this change. Will add details soon.

@johanvanderkuijl
Copy link

Any update on a possible merge?

Copy link

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is good, but this needs tests. Can you add some simple ones here for this @original-brownbear ?

@juv
Copy link

juv commented May 4, 2018

@original-brownbear any chance to get this merged soonish?

@rbkasat
Copy link

rbkasat commented Nov 5, 2018

Can someone merge this? We need this asap.

@original-brownbear
Copy link
Contributor Author

@jsvd FYI :)

@johanvanderkuijl
Copy link

@original-brownbear The tests are all good, there are no conflicts, can you merge this?

@original-brownbear
Copy link
Contributor Author

@jsvd pong :)

@guillaume7
Copy link

guillaume7 commented Aug 6, 2019

Can you please finalize this merge? Thank you!

@petericebear
Copy link

I have a customer waiting for this to merge. Can we get a timing on the release for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants