-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Application Exploration Dashboard #88
Add New Application Exploration Dashboard #88
Conversation
@@ -0,0 +1,9 @@ | |||
{ | |||
"visState": "{\"type\":\"table\",\"params\":{\"perPage\":10,\"showPartialRows\":false,\"showMeticsAtAllLevels\":false},\"aggs\":[{\"id\":\"1\",\"type\":\"sum\",\"schema\":\"metric\",\"params\":{\"field\":\"TotalBytes\"}},{\"id\":\"2\",\"type\":\"terms\",\"schema\":\"bucket\",\"params\":{\"field\":\"ApplicationTags\",\"size\":50,\"order\":\"desc\",\"orderBy\":\"1\"}},{\"id\":\"3\",\"type\":\"sum\",\"schema\":\"metric\",\"params\":{\"field\":\"TotalPackets\"}}],\"listeners\":{}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this Metric, we want to use Sum of TotalBytesDelta
and Sum of TotalPacketsDelta
to specifically only calculate these metrics over the course of the time window, rather than ALL reports for sessions that were updated in this time window.
I spoke to @lmayron about this over Slack and he said that is the behavior we are trying to display here.
@@ -0,0 +1,9 @@ | |||
{ | |||
"visState": "{\"type\":\"pie\",\"params\":{\"shareYAxis\":true,\"addTooltip\":true,\"addLegend\":true,\"isDonut\":true},\"aggs\":[{\"id\":\"1\",\"type\":\"sum\",\"schema\":\"metric\",\"params\":{\"field\":\"TotalBytes\"}},{\"id\":\"2\",\"type\":\"terms\",\"schema\":\"segment\",\"params\":{\"field\":\"ApplicationFamily.raw\",\"size\":10,\"order\":\"desc\",\"orderBy\":\"1\"}},{\"id\":\"4\",\"type\":\"terms\",\"schema\":\"segment\",\"params\":{\"field\":\"Application\",\"size\":10,\"order\":\"desc\",\"orderBy\":\"1\"}}],\"listeners\":{}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here as above - to sum only the bytes across the time window (rather than ALL bytes for sessions that had updates in the time window) this pie chart 'Slice Size' should use TotalBytesDelta
This reverts commit 4852950.
}, | ||
"version": 1, | ||
"description": "", | ||
"title": "Application Tags by Bandwidth" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to keep finding things individually, I wish I would have caught this before putting up my last comment.
This should be named Application Families By Bandwidth
.
Notice: (1) Tags-->Families (2) capitalize B
in "by".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@craig-cogdill, I don't know about the recommendation for capitalizing the 'B'. In "The Elements of Style", the recommendation would be to not capitalize prepositions unless it is the first or last word. Brian would know for sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@john-gress I agree with you 100%, but all of our other visualizations are named that way :'(
Logger
import to correctly beLogConfig
Jira link - https://jira.logrhythm.com/browse/NM-948
Original (closed) PR here (for comments) - #85
Link to rpm on box - https://logrhythm.box.com/s/f4mi0qsvt7h7jp5zgd4v1t7bkoo9t850