Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new Traffic Dashboards #87

Merged

Conversation

DylanSchneider
Copy link

No description provided.

Copy link

@craig-cogdill craig-cogdill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding in the new dashboards and visualizations works great, but the existing dashboards will still be in ElasticSearch on a customer box, and therefore still visible in the UI. I think we need to discuss a mechanism to remove dashboards from existing machines on upgrade. I am not sure we have done that before, but it shouldn't be too difficult. Let's discuss in person.

"timeRestore": false,
"description": "",
"title": "Traffic Endpoints Dashboard",
"panelsJSON": "[{\"col\":10,\"id\":\"Top-Applications-By-Sessions-(pie)\",\"row\":3,\"size_x\":3,\"size_y\":2,\"type\":\"visualization\"},{\"col\":10,\"id\":\"Top-Applications-By-Metadata-Impact-(pie)\",\"row\":1,\"size_x\":3,\"size_y\":2,\"type\":\"visualization\"},{\"col\":7,\"id\":\"Top-Applications-By-Bandwidth-(pie)\",\"row\":1,\"size_x\":3,\"size_y\":2,\"type\":\"visualization\"},{\"col\":7,\"id\":\"Top-Applications-By-Packet-Count\",\"row\":3,\"size_x\":3,\"size_y\":2,\"type\":\"visualization\"},{\"col\":1,\"id\":\"Top-Applications-By-Sessions-(histogram)\",\"row\":1,\"size_x\":6,\"size_y\":4,\"type\":\"visualization\"},{\"col\":7,\"id\":\"Sum-of-Repeated-Field-Count-by-Application\",\"row\":8,\"size_x\":6,\"size_y\":3,\"type\":\"visualization\"},{\"col\":1,\"id\":\"Average-Repeated-Elements-in-a-Message-(All-Reports)\",\"row\":5,\"size_x\":6,\"size_y\":3,\"type\":\"visualization\"},{\"id\":\"Average-Message-Size-(All-Reports)\",\"type\":\"visualization\",\"size_x\":6,\"size_y\":3,\"col\":7,\"row\":5}]",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you didn't create this visualization, but Top-Applications-By-Sessions-(histogram) is just wrong. It's sorting by Sum of BytesDelta, so we should fix that while we're here too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in person, not going to mess with this visualization.

@josh-cogdill josh-cogdill self-assigned this Jun 19, 2018
"timeRestore": false,
"description": "",
"title": "Traffic Endpoints Dashboard",
"panelsJSON": "[{\"col\":10,\"id\":\"Top-Applications-By-Sessions-(pie)\",\"row\":3,\"size_x\":3,\"size_y\":2,\"type\":\"visualization\"},{\"col\":10,\"id\":\"Top-Applications-By-Metadata-Impact-(pie)\",\"row\":1,\"size_x\":3,\"size_y\":2,\"type\":\"visualization\"},{\"col\":7,\"id\":\"Top-Applications-By-Bandwidth-(pie)\",\"row\":1,\"size_x\":3,\"size_y\":2,\"type\":\"visualization\"},{\"col\":7,\"id\":\"Top-Applications-By-Packet-Count\",\"row\":3,\"size_x\":3,\"size_y\":2,\"type\":\"visualization\"},{\"col\":1,\"id\":\"Top-Applications-By-Sessions-(histogram)\",\"row\":1,\"size_x\":6,\"size_y\":4,\"type\":\"visualization\"},{\"col\":7,\"id\":\"Sum-of-Repeated-Field-Count-by-Application\",\"row\":8,\"size_x\":6,\"size_y\":3,\"type\":\"visualization\"},{\"col\":1,\"id\":\"Average-Repeated-Elements-in-a-Message-(All-Reports)\",\"row\":5,\"size_x\":6,\"size_y\":3,\"type\":\"visualization\"},{\"id\":\"Average-Message-Size-(All-Reports)\",\"type\":\"visualization\",\"size_x\":6,\"size_y\":3,\"col\":7,\"row\":5}]",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these visualizations have (pie) or (histogram) in the title and some do not. Let's make these consistent. It looks like other dashboards have them in the titles, so for those that do not lets add it.

"hits": 0,
"timeRestore": false,
"description": "",
"title": "Traffic Profile Dashboard",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the names of these two dashboards are switched...

This dashboard displays a table with Src & Dest IPs, as well as visualizations about the 'top talkers' - the Src and Dest IPs that account for the most sessions and highest metadata impact.

The other dashboard shows stats about the volume of traffic, the size of the average JSON insertion, etc.

The first description sounds like a dashboard centered around Endpoints, and the second description sounds like a dashboard centered around your traffic profile.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craig-cogdill
Copy link

screen shot 2018-06-19 at 2 03 04 pm

Unintended side effect of renaming that visualization. I think that change should be reverted.

@craig-cogdill craig-cogdill merged commit beeeb11 into logrhythm:4.1.10_NM Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants