Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY FOR REVIEW] Added support table with visualizations and search table #84

Merged
merged 26 commits into from
Apr 9, 2018

Conversation

KjellKod
Copy link

@KjellKod KjellKod commented Mar 22, 2018

screen shot 2018-03-23 at 12 51 56 am

screen shot 2018-03-23 at 12 54 39 am

@KjellKod KjellKod changed the title [MERGE AFTER 3.7.1 RELEASE OR AFTER AGREEMENT WITH PHILIP MAZZA] Added support table with visualizations and search table [MERGE AFTER 3.7.1 RELEASE ] Added support table with visualizations and search table Mar 23, 2018
@KjellKod KjellKod changed the title [MERGE AFTER 3.7.1 RELEASE ] Added support table with visualizations and search table [READY FOR REVIEW] Added support table with visualizations and search table Mar 26, 2018
@Schatzman
Copy link

@KjellKod all of the visualizations work and are visualizing the correct things.

It strikes me that both of these dashboards appear very empty. The visualizations are small and when I have the page fullscreen, there is a lot of empty space at the bottom of both of these dashboards. Could you consider making the visualizations a bit larger so there's not so much empty space?

screen shot 2018-04-06 at 10 31 23 am
screen shot 2018-04-06 at 10 31 16 am

@KjellKod
Copy link
Author

KjellKod commented Apr 6, 2018

@Schatzman the design is on purpose.

@KjellKod
Copy link
Author

KjellKod commented Apr 6, 2018

I hear your feedback @Schatzman

Let me explain the purpose of the design.

I want the support dashboards to not look super polished. By leaving space it enourages the user to drag-and-drop, remove, add visualizations. If the space is completely filled up that is much less likely to happen.

The support dashboards are a starting place.

Unless Liam feels otherwise I intend to leave them as is

@craig-cogdill craig-cogdill self-assigned this Apr 6, 2018
Copy link

@craig-cogdill craig-cogdill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: I hadn't seen Dan's comment before reviewing this, but my feedback in this comment is the same as his above.

In addition to my comments, one other thing of note is that the sizing of these visualizations is much smaller than all of our other dashboards. This causes the dashboard to only take up half of my screen when in full window view. Can you please resize the elements so that in a full window view they take up the full page? When the page is smaller, kibana will auto-shrink them to fit. But on a larger screen, it will only make them as big as their maximum size.

@@ -0,0 +1,11 @@
{
"title":"Support Dashbboard - What",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard

@@ -0,0 +1,11 @@
{
"title":"Support Dashbboard - Where",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@@ -0,0 +1,9 @@
{
"title":"Top Applications By Metadata impact (pie)",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capital I in Impact

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for noticing. addressed.

@craig-cogdill
Copy link

I think we need Liam to weigh in on the naming of the dashboards as well. We might want to change 'Support' to 'Diagnostic' or something.

@KjellKod
Copy link
Author

KjellKod commented Apr 6, 2018

@craig-cogdill updated the spelling bugs. I'm leaving the size and naming of the dashboards as is and will let Liam weigh in on it.

@lmayron
Copy link

lmayron commented Apr 9, 2018

In general, we should rename all the dashboard to remove the "Dashboard" at the end, but we'll do that at a later time.

Diagnostics is a good term for this. It will cause short-term confusion with our Diagnostics menu, but that is proposed to be removed and replaced with LRMetrics.

How about:

  • "Diagnostics: Applications Dashboard"
  • "Diagnostics: IP Dashboard"

I agree that the initial impression of the design is a bit sparse. How about we change them as follows:

  • Add a text box to the top of both with instructions about these special dashboards. We can work on the text separately. Something along the lines of "The Diagnostics: Applications Dashboard is when investigating the performance of a NetMon system. Use this dashboard to determine [...]. It's recommended that you customize this dashboard to suit your specific use cases. For more information, please see [NetMon Help]."
  • Move the four small charts horizontally [][][][] across the top and under the new text box.

@KjellKod KjellKod merged commit f3d494c into logrhythm:4.1.10_NM Apr 9, 2018
@KjellKod KjellKod deleted the 4.1.10_NM__support_dashboard branch April 9, 2018 15:53
@KjellKod
Copy link
Author

KjellKod commented Apr 9, 2018

User story for taking this from beta to version 1.0: https://jira.logrhythm.com/browse/NM-1049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants