-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY FOR REVIEW] Added support table with visualizations and search table #84
[READY FOR REVIEW] Added support table with visualizations and search table #84
Conversation
KjellKod
commented
Mar 22, 2018
•
edited
Loading
edited
@KjellKod all of the visualizations work and are visualizing the correct things. It strikes me that both of these dashboards appear very empty. The visualizations are small and when I have the page fullscreen, there is a lot of empty space at the bottom of both of these dashboards. Could you consider making the visualizations a bit larger so there's not so much empty space? |
@Schatzman the design is on purpose. |
I hear your feedback @Schatzman Let me explain the purpose of the design. I want the support dashboards to not look super polished. By leaving space it enourages the user to drag-and-drop, remove, add visualizations. If the space is completely filled up that is much less likely to happen. The support dashboards are a starting place. Unless Liam feels otherwise I intend to leave them as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: I hadn't seen Dan's comment before reviewing this, but my feedback in this comment is the same as his above.
In addition to my comments, one other thing of note is that the sizing of these visualizations is much smaller than all of our other dashboards. This causes the dashboard to only take up half of my screen when in full window view. Can you please resize the elements so that in a full window view they take up the full page? When the page is smaller, kibana will auto-shrink them to fit. But on a larger screen, it will only make them as big as their maximum size.
@@ -0,0 +1,11 @@ | |||
{ | |||
"title":"Support Dashbboard - What", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard
@@ -0,0 +1,11 @@ | |||
{ | |||
"title":"Support Dashbboard - Where", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
@@ -0,0 +1,9 @@ | |||
{ | |||
"title":"Top Applications By Metadata impact (pie)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capital I
in Impact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for noticing. addressed.
I think we need Liam to weigh in on the naming of the dashboards as well. We might want to change 'Support' to 'Diagnostic' or something. |
@craig-cogdill updated the spelling bugs. I'm leaving the size and naming of the dashboards as is and will let Liam weigh in on it. |
In general, we should rename all the dashboard to remove the "Dashboard" at the end, but we'll do that at a later time. Diagnostics is a good term for this. It will cause short-term confusion with our Diagnostics menu, but that is proposed to be removed and replaced with LRMetrics. How about:
I agree that the initial impression of the design is a bit sparse. How about we change them as follows:
|
User story for taking this from beta to version 1.0: https://jira.logrhythm.com/browse/NM-1049 |