Replace Dependency on fieldMap.js with mappings API Call [merge with WWW and PB] #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweltman
commented
May 25, 2017
alexweltman
commented
- goes with PRs in Protobuffers and www
- uses API route created in my www PR
- queries are not auto-capitalized when saved as query rules
alexweltman
changed the title
|
👍 |
KjellKod
reviewed
Jun 2, 2017
packaging/kibana.spec
Outdated
| @@ -56,6 +56,10 @@ if [ -e /usr/local/%{name}-%{kibana_version}-linux-x64/refreshKibanaIndex.sh ]; | |||
| rm /usr/local/%{name}-%{kibana_version}-linux-x64/refreshKibanaIndex.sh | |||
| fi | |||
|
|
|||
| if [ -e /usr/local/%{name}-%{kibana_version}-linux-x64/src/public/netmon_libs/fieldMap.js ]; then | |||
There was a problem hiding this comment.
This file does not seem to be present on my box, nor on any QA box I have checked.
KjellKod
suggested changes
Jun 2, 2017
packaging/kibana.spec
Outdated
| @@ -56,6 +56,10 @@ if [ -e /usr/local/%{name}-%{kibana_version}-linux-x64/refreshKibanaIndex.sh ]; | |||
| rm /usr/local/%{name}-%{kibana_version}-linux-x64/refreshKibanaIndex.sh | |||
| fi | |||
|
|
|||
| if [ -e /usr/local/%{name}-%{kibana_version}-linux-x64/src/public/netmon_libs/fieldMap.js ]; then | |||
There was a problem hiding this comment.
The only location for this file is under /usr/local/www/probe/skin/js/fieldMap.js
* so removal is unnecessary
KjellKod
approved these changes
Jun 5, 2017
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.