Minor tweaks to Ingress/Egress traffic dashboard #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 @craig-cogdill merge when ready |
|
👎 : Traffic-Direction-By-Bandwidth isn't included in the PR |
|
Good catch @alexweltman. I agree with your find. @craig-cogdill please address this. |
|
@john-gress, @shwetabhandare, @KjellKod, one of us needs to take this and fix it. |
|
👍 |
|
Thanks @alexweltman. Whoever else is looking at this PR, you need to pull my kibana branch and make sure that the dashboard is loaded properly. |
|
I did pull your branch and here is what I saw: |
|
Reloaded the rules and the dashboard worked. Not sure why it didn't work earlier. But you got my 👍 |
|
nice traffic bandwidth load is added. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are updates I went over with Rob on Friday. Most language/spelling changes and also changing TotalBytesDelta to just TotalBytes