Added field name capitalization to discover and visualize #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweltman
commented
Jul 5, 2016
alexweltman
commented
- Added field name capitalization to queries on the discover and visualize tabs
- fixed broken time ranges being sent to audit log
| var notify = new Notifier({ | ||
| location: 'Dashboard' | ||
| }); | ||
| var notify = new Notifier({ |
There was a problem hiding this comment.
here I just removed the link function cause it's no longer needed, that functionality was moved to the searchAuditor service and to $scope.filterResults. The rest of the changes is fixing indentations
alexweltman
changed the title
alexweltman
changed the title
| }; | ||
| var _ = require('lodash'); | ||
| var moment = require('moment'); | ||
| var angular = require('angular'); |
There was a problem hiding this comment.
kibana does this on every file that uses an angular method like angular.copy
|
|
|
ha ha ha ... Is that a plus one @sammccord ? |
|
@alexweltman is this for 3.1.2? |
|
👍 reviewed & tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.