Add Capture True filter to FileRecon DB / Add Captured column to SMTP Table #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2016 15:07
File Recon is now filtered on Captured True and Attach True
Conflicts: resources/dashboards/File-Reconstruction-Dashboard.json resources/dashboards/SMTP-Trends-Dashboard.json resources/searches/SMTP-Table.json
| "hits": 0, |
There was a problem hiding this comment.
I don't see any substantive changes in this file.
|
👍 |
| "description": "", | ||
| "title": "SMTP Trends Dashboard", | ||
| "panelsJSON": "[{\"id\":\"Top-10-Email-Senders\",\"type\":\"visualization\",\"size_x\":3,\"size_y\":3,\"col\":7,\"row\":1},{\"id\":\"Top-10-Email-Subjects\",\"type\":\"visualization\",\"size_x\":3,\"size_y\":3,\"col\":7,\"row\":4},{\"id\":\"Top-10-Email-Sender-Domains\",\"type\":\"visualization\",\"size_x\":3,\"size_y\":3,\"col\":10,\"row\":4},{\"id\":\"Top-10-Attachment-Types-By-Count\",\"type\":\"visualization\",\"size_x\":3,\"size_y\":3,\"col\":10,\"row\":1},{\"id\":\"Sessions-Over-Time\",\"type\":\"visualization\",\"size_x\":6,\"size_y\":6,\"col\":1,\"row\":1},{\"id\":\"SMTP-Table\",\"type\":\"search\",\"size_x\":12,\"size_y\":5,\"col\":1,\"row\":7,\"columns\":[\"Attach\",\"Captured\",\"SenderEmail\",\"ReceiverEmail\",\"Subject\",\"TotalBytes\"],\"sort\":[\"TimeUpdated\",\"desc\"]}]", |
There was a problem hiding this comment.
@john-gress and other reviewers, this DB is needed. If you look towards the bottom of this line, the STMP-Table's columns have been updated to include Captured, whereas the old DB doesn't.
|
👍 |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Amanda's PR after talking with Rob
The mismatched formatting and order of keys is because I used the new export script to generate the files. The python dictionary that they are printed from has no ordering of keys, so the key/value pairs are in a different order. This makes no difference for ES insertion.
I will look into how the script could sort the keys in the future.