Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved NM Services to netmon_libs #34

Merged
merged 3 commits into from
Apr 7, 2016

Conversation

alexweltman
Copy link

  • all angular services WE add are kept in netmon_libs for easy kibana updating
  • moved function from kibana controller into it's own service for the same reason (keep as much of our code out of kibana files as possible)

@ghost
Copy link

ghost commented Apr 6, 2016

👍

@@ -0,0 +1,22 @@
define(function (require) {

var app = require('modules').get('app/dashboard');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I give up on consistent indentation in javascript files?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just the kibana files haha. lemme fix it

@john-gress
Copy link

👍 But indentation: 😢

@alexweltman alexweltman merged commit 2f34eb1 into logrhythm:4.1.4_NM Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants