Fix cov script #12
Merged
Fix cov script #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2018
added 3 commits
June 27, 2018 10:28
josh-cogdill
suggested changes
Jun 28, 2018
scripts/CodeCoverage.py
Outdated
| for root, dirs, files in os.walk(rpmbuild_dir): | ||
| if 'UnitTestRunner.dir' in root: | ||
| continue | ||
| for f in files: |
There was a problem hiding this comment.
I would name the loop variable something more descriptive other than f. Maybe file
There was a problem hiding this comment.
just don't want to name it file because then it'll overwrite that keyword. will use filename.
scripts/CodeCoverage.py
Outdated
| os.chdir(LAUNCH_DIR + '/coverage') | ||
|
|
||
| gcovr_whitelist = generate_gcovr_filter(formatted_user_list=format_user_list(user_list=USER_WHITELIST), | ||
| default_list=DEFAULT_WHITELIST) | ||
| gcovr_blacklist = generate_gcovr_filter(formatted_user_list=format_user_list(user_list=USER_BLACKLIST), | ||
| default_list=DEFAULT_BLACKLIST) | ||
| copy_coverage_files_into_cov_dir(object_dir=OBJ_DIR, launch_dir=LAUNCH_DIR) | ||
|
|
||
| # ProbeTransmogrifier builds both Probe_Transmogrifier and ProbeTransmogrifier. ProbeTransmogrifier has the code we want to cover, not Probe_Transmnogrifier |
There was a problem hiding this comment.
typo at the end of this comment Probe_TransmNogrifier
added 9 commits
July 2, 2018 11:21
josh-cogdill
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://jira.logrhythm.com/browse/NM-1104
Related PRs:
Adding CC to repo Builds
nm-core - https://github.com/logrhythm/nm-core/pull/29
nm-stats - https://github.com/logrhythm/nm-stats/pull/1
nm-tools - https://github.com/logrhythm/nm-tools/pull/4
nm-protobuffers - https://github.com/logrhythm/nm-protobuffers/pull/4
nm-setup - https://github.com/logrhythm/nm-setup/pull/8
inverted-index-file - https://github.com/logrhythm/inverted-index-file/pull/2
nm-dpi - https://github.com/logrhythm/nm-dpi/pull/10
nm-lua-executer - https://github.com/logrhythm/nm-lua-executer/pull/4
probe-transmogrifier - https://github.com/logrhythm/probe-transmogrifier/pull/1
syslog-sender - https://github.com/logrhythm/syslog-sender/pull/1
lross - https://github.com/logrhythm/lross/pull/3
FileIO - logrhythm/FileIO#33
DeathKnell - logrhythm/DeathKnell#18
QueueNado - logrhythm/QueueNado#54
StopWatch - logrhythm/StopWatch#29
MurMurHash - logrhythm/MurMurHash#15
Adding CC to CI Build and Artifacts
CodeCoverage - #12
nm-fabric - https://github.com/logrhythm/nm-fabric/pull/18
nm-docker - https://github.com/logrhythm/nm-docker/pull/14
nm-thirdparty - https://github.com/logrhythm/nm-thirdparty/pull/16