Dev 49484 add the rbac for the minishift case #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
October 12, 2018 10:10
…-user-to-specify-a-parent to develop * commit '0069c29ebac9b26de692b3690c136fefd091e0ff': DEV-39965: Allow the user to specify a parent group during installation DEV-39965: Allow the user to specify a parent group during installation DEV-39965: Allow the user to specify a parent group during installation
…pecifying-an-escalation to develop * commit '19cb6d08103676af5b9b3cfcf6baf4de2b6853e9': DEV-39795: Support specifying an escalation chain for collectors DEV-39795: Support specifying an escalation chain for collectors
…onfiguration-support-in to develop * commit '0f49f008ecf732e7ea47361e6f01a775562132e5': DEV-40319: Add new configuration support in helm chart
…ing device/collector group
…the-capitalization-of to develop * commit '95530db1a8ac6cda72cd025f55ea7eaf99680914': DEV-40760: Maintain the capitalization of the cluster name when creating device/collector group
…collector-group-name-s to develop * commit 'cdc2c497bf71cb50493385d18f4cc0575bd8fdc7': DEV-41170: Make the collector group name's casing the same as user defined
…lector Groups for K8s Monitoring
…set-controller-allow-user to develop * commit '8382dde2d8c569c6827481aed5ccd833642046f3': DEV-49511 [collectorset-controller] Allow user to select existing Collector Groups for K8s Monitoring
…-add-nodes-stats-to-collector to develop * commit '0c256b76b68ff1cad7fad7b0a144efc39feed8f2': DEV-49484 Check and add nodes/stats to collector ClusterRole in helm charts
JeremyTangCD
commented
Mar 20, 2019
| @@ -1,7 +1,7 @@ | |||
| apiVersion: v1 | |||
| description: Automated Kubernetes monitoring | |||
| name: argus | |||
| version: 0.3.0 | |||
| version: 0.5.0 | |||
There was a problem hiding this comment.
@woz5999
Pls check if the version change is ok
There was a problem hiding this comment.
why are we skipping a minor version? Should be 0.4.0
There was a problem hiding this comment.
Actually, we had changed the minor version to 0.4.0 in https://github.com/logicmonitor/k8s-helm-charts/pull/28/files
I do not know why the master branch still show the previous file
JeremyTangCD
commented
Mar 20, 2019
| @@ -1,7 +1,7 @@ | |||
| apiVersion: v1 | |||
| description: Automated collector management | |||
| name: collectorset-controller | |||
| version: 0.1.0 | |||
| version: 0.2.0 | |||
There was a problem hiding this comment.
@woz5999
Pls check if the version change is ok
|
@JeremyTangCD There are merge conflicts that need to resolved |
vkumbhar94
pushed a commit
that referenced
this pull request
Sep 2, 2020
…DEV-62719-helm-chart-updates-allow-for-pod-priorityclass to develop * commit '38aa383f4d7346d74fa17bbebdd6d4ef0a8a29e1': DEV-62719 added priorityClassName in Argus & Collectorset-controller helm charts
vkumbhar94
pushed a commit
that referenced
this pull request
Sep 10, 2020
…helm-chart-updates-allow-for-pod-priorityclass to develop * commit '38aa383f4d7346d74fa17bbebdd6d4ef0a8a29e1': DEV-62719 added priorityClassName in Argus & Collectorset-controller helm charts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev 49484 add the rbac for the minishift case