fix: handle pending validation runs during field unmounting

logaretm · Mar 3, 2021 · ef5a7cc · ef5a7cc
1 parent 89825cb
commit ef5a7cc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/vee-validate/src/useField.ts b/packages/vee-validate/src/useField.ts
@@ -123,7 +123,7 @@ export function useField<TValue = unknown>(
         bails,
       });
     } else {
-      result = (await form.validateSchema())[unref(name)];
+      result = (await form.validateSchema())[unref(name)] ?? { valid: true, errors: [] };
     }
 
     meta.pending = false;

diff --git a/packages/vee-validate/src/useForm.ts b/packages/vee-validate/src/useForm.ts
@@ -521,16 +521,16 @@ async function validateYupSchema<TValues>(
       return err.inner || [];
     });
 
-  const fields = form.fieldsById.value;
+  const fieldsById = form.fieldsById.value || {};
   const errorsByPath = errors.reduce((acc, err) => {
     acc[err.path as keyof TValues] = err;
 
     return acc;
   }, {} as Record<keyof TValues, ValidationError>);
 
   // Aggregates the validation result
-  const aggregatedResult = keysOf(fields).reduce((result: Record<keyof TValues, ValidationResult>, fieldId) => {
-    const field: PrivateFieldComposite | PrivateFieldComposite[] = fields[fieldId];
+  const aggregatedResult = keysOf(fieldsById).reduce((result: Record<keyof TValues, ValidationResult>, fieldId) => {
+    const field: PrivateFieldComposite | PrivateFieldComposite[] = fieldsById[fieldId];
     const messages = (errorsByPath[fieldId] || { errors: [] }).errors;
     const fieldResult = {
       errors: messages,