Enhance Image Validation and Handling #155

[loftwah]

Pull Request for Linkarooie

Summary

This PR enhances the image validation process in the User model and OpenGraphImageGenerator. It makes the validation more lenient while maintaining security, improves error handling, and optimizes the handling of DigitalOcean Spaces URLs.

Changes

• What was added/changed?

  • Updated validate_image_url method in User model to be more lenient
  • Modified valid_image_url? and download_image methods in OpenGraphImageGenerator
  • Added immediate acceptance of DigitalOcean Spaces URLs without additional validation
  • Implemented warning logs instead of blocking saves for potentially invalid image URLs
  • Added timeout settings to fetch_head method to prevent long-hanging requests

• Why is this necessary?

  • To reduce unnecessary errors and save failures
  • To improve handling of DigitalOcean Spaces URLs
  • To provide better user experience by allowing saves even when image URLs might not be immediately verifiable
  • To enhance system robustness in handling various network and URL-related issues

Testing

• How did you test your changes?

  • Ran existing test suite to ensure no regression
  • Manually tested image upload and profile update processes
  • Verified handling of various URL types, including DigitalOcean Spaces URLs and potentially invalid URLs

• Any specific instructions for testing?

  • Test profile updates with various types of image URLs (valid, invalid, DigitalOcean Spaces)
  • Check logs for appropriate warnings when using potentially invalid image URLs
  • Verify that DigitalOcean Spaces URLs are accepted without additional validation

Checklist

• Code follows project guidelines.
• Changes have been tested.
• Relevant documentation has been updated.

Additional Notes

The changes are designed to be backwards compatible. No database migrations or environment changes are required. The existing test suite adequately covers the new behavior, so no additional tests were added.

[Aaryanpal]

LGTM!