Feature/tailscale network tools #1589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM overall, a couple of smaller comments here and there.
Bigger topic: What do you think of moving all logging to our logger implementation?
Right now it always prints to Stdout/err which will make it harder for us in the future to expose these commands from within a workspace.
janekbaraniewski
approved these changes
Jan 24, 2025
|
@pascalbreuninger good point, I guess this depends on how we intend to use the tool. So far I have been running in an SSH session on my workspace. I suppose the logger is only needed if we execute the commands in the SSH tunnel pragmatically? Would we do this? If not logging to STDOUT should suffice. Let me know if this needs to be implemented but I thought this would be run manually by the user |
bkneis
force-pushed
the
feature/tailscale-network-tools
branch
from
b05bb28 to
1ffbb01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the addition of the following CLI commands
devpod ts ping,devpod ts netcheck,devpod ts statusanddevpod ts metrics. Each are the same as runningtailscaleinstead ofdevpod tsin the CLI. They were taken from https://github.com/tailscale/tailscale/tree/v1.78.3/cmd/tailscale/cli where the CLI tool was ported to cobra and the tailscaleLocalClientwas injected by starting a tailscale server usingpkg/tailscaleand returning it's userspace local client.One open question in this PR are my changes to
tsnet.go. I changed the call toStartwithUp, looking at the docs Start and Up are the same except Up waits for the client to be connected. I thought this would be preferably than having to poll a local tailscale endpoint to check it. I then passed a channel to signal when the call toStarthad completed callingUp(therefore was connected to the network) and before blocking on the context. Let me know your thoughts