fix/POD 1050 upgrade existing pro worksapces #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pascalbreuninger
commented
Nov 13, 2024
pascalbreuninger
commented
- chore(ui): hide new providers in open source UI
- chore(ui): remove console.log
- fix(cli): resolve provider options after auto-upgrade in pro
pascalbreuninger
force-pushed
the
fix/POD-1050-upgrade-existing-pro-worksapces
branch
from
11bdb7f
to
7057d5f
Compare
bkneis
reviewed
Nov 13, 2024
| @@ -73,5 +74,10 @@ func (cmd *UpdateProviderCmd) Run(ctx context.Context, args []string) error { | |||
| return fmt.Errorf("update provider %s: %w", provider.Name, err) | |||
| } | |||
|
|
|||
| err = providercmd.ConfigureProvider(ctx, provider, devPodConfig.DefaultContext, []string{}, false, false, nil, log.Discard) | |||
There was a problem hiding this comment.
nit: I think it would be nicer to move common functionality to pkg and not have the commands import each other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.