Build linux and darwin arm64 binary #43
Conversation
|
Thank you very much for this pull request @wiget - looks great 2 updates i would love to see:
|
|
closes #43 |
|
@loeffel-io If by different darwin version you mean version for Apple Silicon then this is planned for Go 1.16. I will look at docker image for linux/arm64. |
|
Hey @wiget , crazy that darwin arm64 is not released yet Alright 👍 |
|
@loeffel-io I finished Docker part too. Please review. |
|
@loeffel-io anything missing or need to be adjusted before merge? |
|
@loeffel-io I'm trying to bring Renovate to arm64. As ls-lint is dependency of Renovate this PR is pre-requisite of my future work on the topic. |
|
Thanks @wiget, i currently try to dig into that - first of all: you must update the package.json version to release the new ls-lint version: v1.10.0 edit: done |
|
Thanks for the update but the branch is also very important ✌️ |
|
@loeffel-io I'm not sure if I understand correctly. Can you describe when Docker image should be build and published to Docker Hub? Than I will try to translate this into |
|
@loeffel-io any changes needed or this PR can be merged as-is? |
|
@loeffel-io Any chance for this PR? 🙃 |
|
@loeffel-io Good news! golang 1.16 released with support for Apple Silicon. I added relevant changes to build darwin/arm64 version. |
|
Thank you very much! I think the biggest problem is that my ci works only for amd images - i need some more time to dig into this! sorry for the delay |
|
Any updates? I tries to install ls-lint on my M1 Mac mini but failed... |
|
Any news on merging this PR? |
.drone.yml
Outdated
| image: plugins/manifest | ||
| settings: | ||
| auto_tag: true | ||
| ignore_missing: true |
There was a problem hiding this comment.
why do we want to ignore missing source images?
There was a problem hiding this comment.
I don't think is needed. I just copied this from some other project.
|
v1.10.0-beta.1 is online; please test the arm versions |
|
Looks like it works on RockPi 4 root@288e2632b2e9:/tmp/test# npx @ls-lint/[email protected]
npx: installed 1 in 2.723s
2021/06/08 14:21:31 ./node_modules failed for rules: kebabcase
2021/06/08 14:21:31 ./node_modules/.bin failed for rules: kebabcase
2021/06/08 14:21:31 ./node_modules/@ls-lint failed for rules: kebabcase
root@288e2632b2e9:/tmp/test# uname -a
Linux 288e2632b2e9 5.10.21-rockchip64 #21.02.3 SMP PREEMPT Mon Mar 8 01:05:08 UTC 2021 aarch64 GNU/Linux |
|
Would love to hear more feedback about the v1.10.1-beta.1 before release ✌️ |
|
@loeffel-io, thanks for changes, but I think I have found a typo: https://github.com/loeffel-io/ls-lint/blob/v1.10.0-beta.1/npm/bin/cli.js#L29 I have tested this on M1 |
|
@padevone that's true. Are you able to submit PR with the fix? If not I will create PR later this week. |
|
would love to see a PR for this, currently at holidays @wiget |
This fixes a typo and is related to loeffel-io#43
|
Here: #57 |
This allow using ls-lint on Linux run on arm64 CPU (Raspberry Pi4, Rock Pi4, AWS EC2 with AWS Graviton CPU (A1, T4g, C6g, M6g, R6g)).