Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 90th %ile to the stats page #945

Merged
merged 1 commit into from
Oct 31, 2019
Merged

add 90th %ile to the stats page #945

merged 1 commit into from
Oct 31, 2019

Conversation

myzhan
Copy link
Contributor

@myzhan myzhan commented Jan 15, 2019

It works like 0e285cc

known issues:

  1. because the response time greater than 100ms is rounded, when calculate response time percentile from response_times, the result may be greater than the max response time.

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #945 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
+ Coverage   66.55%   66.62%   +0.06%     
==========================================
  Files          14       14              
  Lines        1438     1438              
  Branches      226      226              
==========================================
+ Hits          957      958       +1     
  Misses        430      430              
+ Partials       51       50       -1
Impacted Files Coverage Δ
locust/web.py 77.31% <ø> (ø) ⬆️
locust/stats.py 78.63% <0%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8eb37...7dcc147. Read the comment docs.

@@ -107,6 +107,7 @@ <h2>Change the locust count</h2>
<th class="stats_label numeric" href="#" data-sortkey="num_requests" title="Number of successful requests"># requests</th>
<th class="stats_label numeric" href="#" data-sortkey="num_failures" title="Number of failures"># fails</th>
<th class="stats_label numeric" href="#" data-sortkey="median_response_time" title="Median response time">Median (ms)</th>
<th class="stats_label numeric" href="#" data-sortkey="ninetieth_response_time" title="Ninetieth percentile response time, because the response time greater than 100ms is rounded, you may see it greater than the max response time">90%ile (ms)</th>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a short title like: Ninetieth percentile or 90 percentile

@awcodify
Copy link

Screen Shot 2019-06-20 at 19 17 02

The layout seems broken

@myzhan
Copy link
Contributor Author

myzhan commented Jun 20, 2019

@awcodify The layout is changed by this PR

#938

@cyberw cyberw merged commit 0e79c66 into locustio:master Oct 31, 2019
@cyberw
Copy link
Collaborator

cyberw commented Oct 31, 2019

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants