Switch from using optparse to argparse for command line arguments #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
==========================================
+ Coverage 72.45% 72.57% +0.12%
==========================================
Files 17 17
Lines 1706 1703 -3
Branches 255 254 -1
==========================================
Hits 1236 1236
+ Misses 408 405 -3
Partials 62 62
Continue to review full report at Codecov.
|
|
LGTM. @jdufresne , if you fix the conflicts I think we should merge this. @heyman , do you agree? |
|
Yes, sounds good! |
The Python module optparse is deprecated and is no longer receiving updates. From the Python documentation: https://docs.python.org/3/library/optparse.html > Deprecated since version 3.2: The optparse module is deprecated and > will not be developed further; development will continue with the > argparse module. Can take advantage of the argpares API by making the following cleanups: Remove action='store'. It is the default. https://docs.python.org/3/library/argparse.html#action > 'store' - This just stores the argument’s value. This is the default > action. Remove default=None. It is the default. https://docs.python.org/3/library/argparse.html#default > The default keyword argument of add_argument(), whose value defaults > to None, ... Remove dest='...', when it matches the first long option, which is the argparse default. https://docs.python.org/3/library/argparse.html#dest > For optional argument actions, the value of dest is normally inferred > from the option strings. ArgumentParser generates the value of dest by > taking the first long option string and stripping away the initial -- > string. [...] Any internal - characters will be converted to _ > characters to make sure the string is a valid attribute name. Remove default=False for type='store_true' as it is an implied default: https://docs.python.org/3/library/argparse.html#action > 'store_true' and 'store_false' - These are special cases of > 'store_const' used for storing the values True and False respectively. > In addition, they create default values of False and True > respectively. Use argparse builtin version support: https://docs.python.org/3/library/argparse.html#action > 'version' - This expects a version= keyword argument in the > add_argument() call, and prints version information and exits when > invoked
|
Rebased 🙂 |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python module optparse is deprecated and is no longer receiving updates. From the Python documentation:
Can take advantage of the argpares API by making the following cleanups:
Remove
default=None. It is the default.https://docs.python.org/3/library/argparse.html#default
Remove
dest='...', when it matches the first long option, which is the argparse default.https://docs.python.org/3/library/argparse.html#dest
Remove default=False for type='store_true' as it is an implied default:
https://docs.python.org/3/library/argparse.html#action
Use argparse builtin version support:
https://docs.python.org/3/library/argparse.html#action