-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow skipping the logging setup #738
Conversation
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
==========================================
- Coverage 66.1% 66.08% -0.03%
==========================================
Files 14 14
Lines 1422 1424 +2
Branches 224 225 +1
==========================================
+ Hits 940 941 +1
- Misses 431 432 +1
Partials 51 51
Continue to review full report at Codecov.
|
I've not used Codecov before so I'm finding it difficult to understand what threshold I need to meet. Let me know what is needed and I'll rectify it. |
I was trying to use pudb to do some simple debugging, but it fails to open the console interface due to the wrapping of standard error/output |
@soulrebel This PR would allow you to skip the call to |
This should be merged with the code base -- vital when testing code or else the unittestpy.py with error out with -- 'StdOutWrapper' object has no attribute 'getvalue' -- if this functionality could be incorporated into the wrapper that would be cool, but it looked like the getvalue function had other dependencies within the unittestpy.py module. |
This LGTM. Anyone have objections to me merging this? |
Also ran into this issue, and would like this to be merged! |
New CLI option:
This would allow people to setup their own logging configuration. It would also provide a workaround for #163.