Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flask.jsonify for json responses #725

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Conversation

hyperair
Copy link
Contributor

This ensures that all json responses have the correct mimetype without needing
the extra boilerplate to set the content-type header.

This helps let extensions like JSONViewer do the right thing when examining JSON responses like /stats/requests

This ensures that all json responses have the correct mimetype without needing
the extra boilerplate to set the content-type header.
@codecov
Copy link

codecov bot commented Jan 23, 2018

Codecov Report

Merging #725 into master will decrease coverage by 3.32%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
- Coverage   69.25%   65.93%   -3.33%     
==========================================
  Files          14       14              
  Lines        1633     1374     -259     
  Branches      292      214      -78     
==========================================
- Hits         1131      906     -225     
+ Misses        445      421      -24     
+ Partials       57       47      -10
Impacted Files Coverage Δ
locust/web.py 77.31% <60%> (-8.69%) ⬇️
locust/runners.py 51.31% <0%> (-12.61%) ⬇️
locust/core.py 87.82% <0%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 387e7a8...d7c8ad3. Read the comment docs.

@heyman heyman merged commit add0675 into locustio:master Jan 23, 2018
@heyman
Copy link
Member

heyman commented Jan 23, 2018

Looks good, thanks!

@hyperair hyperair deleted the jsonify branch January 23, 2018 13:46
@cgoldberg cgoldberg added this to the 0.9.0 milestone Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants