Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the spelling of "occurences" on the output text #706

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

ethansmith-wf
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 14, 2017

Codecov Report

Merging #706 into master will increase coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   65.72%   65.79%   +0.07%     
==========================================
  Files          14       14              
  Lines        1380     1380              
  Branches      214      214              
==========================================
+ Hits          907      908       +1     
  Misses        425      425              
+ Partials       48       47       -1
Impacted Files Coverage Δ
locust/stats.py 78.35% <0%> (ø) ⬆️
locust/clients.py 89.88% <0%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95118e3...156597f. Read the comment docs.

@cgoldberg
Copy link
Member

👍 LGTM .. merging it now.
hopefully, that was the only occurrence of occurence! :))

@cgoldberg cgoldberg merged commit 5e1ccc5 into locustio:master Dec 15, 2017
@cgoldberg
Copy link
Member

cgoldberg commented Dec 15, 2017

hopefully, that was the only occurrence of occurence! :))

of course.. as soon as I merged it, I actually checked. Feel free to submit a PR for the 16 other misspellings of "occurence":

$ grep -ir --exclude-dir='.git' "occurence" . | wc -l
16
$ grep -ir --exclude-dir='.git' "occurence" .
./locust/templates/index.html:                            <th class="exception_occurences stats_label" data-sortkey="1"># occurences</th>
./locust/templates/index.html:            <td><%= this.occurences %></td>
./locust/templates/index.html:            <td class="occurences"><%= this.count %></td>
./locust/runners.py:        occurence_count = dict([(l.__name__, 0) for l in self.locust_classes])
./locust/runners.py:                    logger.info("All locusts hatched: %s" % ", ".join(["%s: %d" % (name, count) for name, count in six.iteritems(occurence_count)]))
./locust/runners.py:                occurence_count[locust.__name__] += 1
./locust/test/test_stats.py:        self.assertEqual(2, list(self.stats.errors.values())[0].occurences)
./locust/static/style.css:#exceptions th.exception_occurences {
./locust/static/style.css:#exceptions td.occurences {
./locust/stats.py:    def __init__(self, method, name, error, occurences=0):
./locust/stats.py:        self.occurences = occurences
./locust/stats.py:        self.occurences += 1
./locust/stats.py:            "occurences": self.occurences
./locust/stats.py:            data["occurences"]
./locust/stats.py:            global_stats.errors[error_key].occurences += error["occurences"]
./locust/stats.py:        console_logger.info(" %-18i %-100s" % (error.occurences, error.to_name()))

@madmaze
Copy link

madmaze commented Dec 15, 2017

Here's a fix to this I put together a few months ago: madmaze@2327a94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants