Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add units to table #537

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Add units to table #537

merged 1 commit into from
Feb 16, 2017

Conversation

benrudolph
Copy link
Contributor

@benrudolph benrudolph commented Feb 15, 2017 •
edited
Loading

It wasn't clear to me what units were being displayed in the table. Assuming it was milliseconds and adding it in the table so it's clear. Thoughts?

@heyman
Copy link
Member

heyman commented Feb 15, 2017

Sounds good, but maybe it would be enough to add it to the title attribute of the <th> in order to add less clutter the UI?

@benrudolph
Copy link
Contributor Author

👍 agree with that, will update

@justiniso justiniso added this to the 0.8.0 milestone Feb 15, 2017
@justiniso
Copy link
Member

Awesome, thanks for this!

@justiniso justiniso closed this Feb 16, 2017
@justiniso justiniso reopened this Feb 16, 2017
@justiniso justiniso merged commit a40ba74 into locustio:master Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
web interface
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@benrudolph @heyman @justiniso