-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added introduction of Boomer #510
Conversation
@myzhan I'd say don't change anything in that index file other than the link, that commit will retrigger the CI and it should pass. |
good idea... there shouldn't be unrelated whitespace changes in a PR.
That's not causing CI to fail. travis-ci fails on python2.6 because it's trying to install gevent 1.2 which doesn't work with 2.6. We should just drop 2.6 support to fix that (see: #515) for other versions of Python, travis-ci is failing with:
It looks like we have some bad tests in test_stats.py... hopefully someone has time to fix. |
@chris-surge sorry for the whitespaces, atom added them. I will check this later. @cgoldberg I fixed some tests, in another PR. |
@chris-surge By default, atom removes trailing whitespace. |
@myzhan Can you repush this? The tests should pass now. |
@mbeacom I reopened this PR, the tests had passed. |
This lgtm, @cgoldberg you want to merge this? |
the whitespace changes were not removed as asked, but merging anyway :) |
Now, we are able to write test scenarios in golang.
add @cgoldberg as a reviewer.