Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added introduction of Boomer #510

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Added introduction of Boomer #510

merged 1 commit into from
Jun 23, 2017

Conversation

myzhan
Copy link
Contributor

@myzhan myzhan commented Jan 9, 2017

Now, we are able to write test scenarios in golang.

add @cgoldberg as a reviewer.

@chris-surge
Copy link

@myzhan I'd say don't change anything in that index file other than the link, that commit will retrigger the CI and it should pass.

@cgoldberg
Copy link
Member

@chris-surge

I'd say don't change anything in that index file other than the link,

good idea... there shouldn't be unrelated whitespace changes in a PR.

retrigger the CI and it should pass.

That's not causing CI to fail. travis-ci fails on python2.6 because it's trying to install gevent 1.2 which doesn't work with 2.6. We should just drop 2.6 support to fix that (see: #515)

for other versions of Python, travis-ci is failing with:

======================================================================
FAIL: test_request_stats_no_content_length (locust.test.test_stats.TestRequestStatsWithWebserver)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/locustio/locust/locust/test/test_stats.py", line 165, in test_request_stats_no_content_length
    self.assertEqual(global_stats.get(path, "GET").avg_content_length, len("This response does not have content-length in the header"))
AssertionError: 0 != 56

It looks like we have some bad tests in test_stats.py... hopefully someone has time to fix.

@myzhan
Copy link
Contributor Author

myzhan commented Jan 19, 2017

@chris-surge sorry for the whitespaces, atom added them. I will check this later.

@cgoldberg I fixed some tests, in another PR.

@myzhan
Copy link
Contributor Author

myzhan commented Jan 20, 2017

@chris-surge By default, atom removes trailing whitespace.

atom/language-python#27

@mbeacom
Copy link
Member

mbeacom commented Jan 30, 2017

@myzhan Can you repush this? The tests should pass now.

@myzhan myzhan closed this Feb 3, 2017
@myzhan myzhan reopened this Feb 3, 2017
@myzhan
Copy link
Contributor Author

myzhan commented Feb 3, 2017

@mbeacom I reopened this PR, the tests had passed.

@aldenpeterson-wf
Copy link
Contributor

This lgtm, @cgoldberg you want to merge this?

@cgoldberg
Copy link
Member

the whitespace changes were not removed as asked, but merging anyway :)

@cgoldberg cgoldberg merged commit 7018f50 into locustio:master Jun 23, 2017
AngelosTheodosiadis pushed a commit to datarobot/locust that referenced this pull request Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants