-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds host name to the header #447
Conversation
I've just seen an issue with this pull request where running in master with a large number of slaves and a large number of failures ruins the header layout. I'll update the css to address this, so wouldn't merge it until I have added another commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hm, not sure about this since it won't work when setting the hostname through the |
@heyman sorry for delay, only just had a chance to look at this again. |
I included a similar change to my recent pull request, only putting it lower in the header. I too only looked at the runner's host, not the locusts. My concern was what if different locusts had different hosts? I think the host in the ui should only display if the runner itself has a host. |
@PayscaleNateW Awesome, your changes were on my todo list of thing's I'd like to improve in locust, so that saves me the work! Do you have a screenshot of your implementation for comparison? With regards to getting the actual host data I agree if they are different it doesn't make sense to display one of them, but if you have to pick I assume you would want to show the one set by the master. Is that an actual use case that people do with locust? |
@thaffenden Yeah, I guess the most sensible thing to do is to only show it if it's been set through the command line options, or in the host attribute of a single Locust class (like you've done). Other than that, I think I would also like to decrease the font-size of the hostname a bit (maybe 14px and normal font-weight), just to make it a little less prominent, and work better with really long hostnames. |
@heyman I've updated the CSS to your recommended values. |
@thaffenden you'll want to pull in the latest changes from master. There have been some style updates to the header. |
@justiniso rebased from master. |
@justiniso @heyman is there anything else you wanted doing to this one or is it good to go? |
Thanks @thaffenden ! |
Adds the host url to the header:
PR #295 does the same thing slightly differently but failed tests and is over a year old so created my own (with less css changes as displaying it with the existing header items keeps the UI more visually consistent).
The max width and word wrap have been set to prevent long urls ruining the layout of whole header.