Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webui Echarts Redraw Request Lines if Changed #2953

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Webui Echarts Redraw Request Lines if Changed #2953

merged 1 commit into from
Oct 24, 2024

Conversation

andrewbaldwin44
Copy link
Collaborator

@andrewbaldwin44 andrewbaldwin44 commented Oct 24, 2024 •
edited
Loading

Proposal

  • If the chart lines change during a render, echarts merges the lines with the existing ones by default. This adds a prop that allows for the lines to be redrawn in the case that they have completely changed
  • Remove the isDarkMode prop from drawing marked lines. The marked lines infer their color from the base axis lineStyle, so removing this prop will save us a useEffect cycle

@andrewbaldwin44 andrewbaldwin44 force-pushed the bugfix/redraw-request-lines branch 2 times, most recently from 3d32731 to d037290 Compare October 24, 2024 09:00
@andrewbaldwin44 andrewbaldwin44 force-pushed the bugfix/redraw-request-lines branch from d037290 to 9635162 Compare October 24, 2024 09:11
@cyberw cyberw merged commit 0b57d3e into locustio:master Oct 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewbaldwin44 @cyberw