-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative grouping #1858
Alternative grouping #1858
Conversation
Serhiy1
commented
Aug 19, 2021
- Add an alternative way to group requests together, do deal with situations where passing in a name parameter is not possible
- Add examples using the alternative grouping approaches.
- Added an example of session patching when working with SDK's
@@ -1,7 +1,7 @@ | |||
.. _testing-other-systems: | |||
|
|||
======================== | |||
Testing non-HTTP systems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe split this into two sections? ”Testing non-HTTP systems” and ”Testing requests-based SDKs”?
Cool stuff!
|
cheers for the feedback, I will do all the items listed out. |
@cyberw All the suggested changes are done though I'm not 100% happy with the function name for the context manager. I think maybe instead of |
Code looks great now! I think you've duplicated the documentation? Also, the new page needs to be added to index.rst to become visible in the left hand menu in the docs. Maybe rename_request is more clear? |
|
Remove duplicated documentation
Looks great! |
Two small issues, now that I see the documentation first hand (https://docs.locust.io/en/latest/) The title is weird, and there is an extra heading that you should probably remove. |
@cyberw agreed, that doesn't look great. I've fixed that, and slightly changed the wording, shall I make another PR? |
Please do! Looks good! I think SDKs is more grammatically correct than SDK's, but that is a detail :) |