Improve logging messages and clean up code after dispatch refactoring (#1809) #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberw
changed the title
I also added comments and docstrings to explain what's going on in some places.
|
let me know when you feel ready to merge. with this + the change in heartbeat messages I think we have enough for another (last?) beta build. |
|
Yes, I'm adding the test for the |
Also add more assertions for `UsersDispatcher._rebalance` in dispatch tests.
|
I think this is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of PR #1809 to address the TODOs and comments that were left on this other PR. PR #1809 was merged in an imperfect (but working) state in order to release another beta of Locust and get feedback from the community as soon as possible.