Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reset stats after hatching is complete #175

Closed
wants to merge 2 commits into from

Conversation

drewtunes
Copy link

The stats reset when hatching starts already and if you hatch slowly, there can be many tasks completed by the time hatching completes. Without this change, those completed tasks are removed from the stats as soon as hatching completes.

@Jahaja
Copy link
Member

Jahaja commented Jul 9, 2014

I do not understand what the problem is with resetting the stats after hatching is complete. This is the normal behaviour of locust for quite some time now. Could you explain it further?

@drewtunes
Copy link
Author

The problem I ran into was that several requests had already been made by the time hatching was complete. If I hatch 90 users at one per second, by the time the 90th user hatched, the first user had already made several requests. By resetting statistics after hatching is complete, the early requests are lost from the statistics.

Sent from my mobile device.

On Jul 9, 2014, at 5:42 PM, Joakim Hamrén [email protected] wrote:

I do not understand what the problem is with resetting the stats after hatching is complete. This is the normal behaviour of locust for quite some time now. Could you explain it further?


Reply to this email directly or view it on GitHub.

@Jahaja
Copy link
Member

Jahaja commented Jul 10, 2014

This is the intended behaviour. The hatching phase will normally contain a good amount of overhead for warming up caches on the target, logging in users, etc. Thus, after the hatching is complete, locust will reset the stats to make sure that we only measure stable, warmed-up, requests.

@spearsem
Copy link

Can this be made configurable? Some load tests may be used to see how throughput and latency vary as the number of users increases, up to an expected saturation point, and traffic prior to fully hatched point will still be meaningful (and will not suffer from unwarm caches, etc., by design).

@heyman
Copy link
Member

heyman commented Oct 19, 2017

@spearsem It is configurable in Locust >= 0.8. Use the —no-reset-stats option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants