Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename hatch rate to spawn rate. Fixes #1405 #1523

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Aug 18, 2020

No description provided.

@cyberw cyberw changed the title Renamed hatch rate to spawn rate. Fixes #1405 Rename hatch rate to spawn rate. Fixes #1405 Aug 18, 2020
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #1523 into master will decrease coverage by 0.01%.
The diff coverage is 76.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
- Coverage   81.50%   81.49%   -0.02%     
==========================================
  Files          28       28              
  Lines        2466     2470       +4     
  Branches      382      383       +1     
==========================================
+ Hits         2010     2013       +3     
- Misses        360      362       +2     
+ Partials       96       95       -1     
Impacted Files Coverage Δ
locust/main.py 19.73% <0.00%> (-0.27%) ⬇️
locust/shape.py 88.88% <ø> (ø)
locust/user/users.py 95.83% <ø> (ø)
locust/runners.py 82.85% <84.61%> (ø)
locust/argument_parser.py 77.19% <100.00%> (+0.20%) ⬆️
locust/event.py 87.50% <100.00%> (ø)
locust/web.py 90.00% <100.00%> (ø)
locust/user/task.py 96.21% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12bfb26...0626cbf. Read the comment docs.

@cyberw cyberw merged commit 10f88e2 into master Aug 18, 2020
@lhupfeldt
Copy link
Contributor

Instead of failing when --hatch-rate is used there should be a deprecation warning and the fail should not happen until release 2.0.

@lhupfeldt
Copy link
Contributor

index.html still says hatch

@cyberw
Copy link
Collaborator Author

cyberw commented Aug 18, 2020

I dont really see a big benefit of deprecating things for any significant amount of time, so I couldnt really be bothered. Maybe I should make the next release be called 2.0 though, just to be clear that it contains breaking changes.

Good catch on index.html, fixing that now.

@cyberw
Copy link
Collaborator Author

cyberw commented Aug 18, 2020

Meh. But you are right. I will deprecate it for a while instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants