-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Feature: Download Report File #1516
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1516 +/- ##
==========================================
- Coverage 82.10% 81.33% -0.77%
==========================================
Files 28 28
Lines 2509 2513 +4
Branches 381 388 +7
==========================================
- Hits 2060 2044 -16
- Misses 354 369 +15
- Partials 95 100 +5
Continue to review full report at Codecov.
|
Hmm... you're adding an entirely new greenlet for this feature. Would it be possible to do this outside locust core? I'm not sure the maintenance will be worth it... |
Sorry, I didn't get the point. |
My main issue is that I dont use the web UI, so I usually cant be bothered with these things :) I'm +/- 0 for this. It looks nice enough. If any of the other maintainers wake up and want to merge this then I'm fine with it. |
oh, haha~ I see, thanks 😁 |
I couldnt help myself and had a look at the report. It looks great. If you just fix the test fail that appeared I will merge! |
I just fixed the conflict, but the coverage decrease 1.18% 😅 |
Ignore the coverage changes, it is a little flaky... |
This comment has been minimized.
This comment has been minimized.
done! 😄 |
thx! |
Hmm... I get warnings from tox/travis about this file descriptor never being closed. Can you fix it? /home/travis/build/locustio/locust/locust/web.py:217: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/travis/build/locustio/locust/locust/static/jquery-1.11.3.min.js' mode='r' encoding='utf8'> |
Ok!
with
in |
Yes. But the opposite of what you just said. So I hope that was what you meant :) |
I accidentally pushed a commit to your master (taojy123/master) Sorry about that 😳 (I'm surprised I was even allowed to) |
Ha~ don't worry |
Export all statistics data to a
html
file, and you can download it to your computer.As follows: