Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User count to CSV history stats #1316

Merged
merged 3 commits into from
Apr 7, 2020
Merged

Add User count to CSV history stats #1316

merged 3 commits into from
Apr 7, 2020

Conversation

heyman
Copy link
Member

@heyman heyman commented Apr 7, 2020

This PR does:

  • Add a column "User count" to the history CSV stats (should fix More information in csv reports #1292)
  • Makes the "Timestamp" column in history CSV the first column
  • Remove the "Download response time history CSV" from Web UI since it has never worked, and fixing it is non-trivial (since we would either have to always store the whole stats history in memory, or always create a disk file somewhere, and I don't think we want to do either).

heyman added 3 commits April 7, 2020 12:39
… UI since it has never worked, and to get it to work is non-trivial.

Better variable names and dosctring in stats_history_csv()
Make Timestamp column the first column in history stats CSV.
@heyman heyman added this to the 1.0 milestone Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #1316 into master will decrease coverage by 0.31%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1316      +/-   ##
==========================================
- Coverage   81.04%   80.73%   -0.32%     
==========================================
  Files          24       24              
  Lines        2163     2154       -9     
  Branches      329      328       -1     
==========================================
- Hits         1753     1739      -14     
- Misses        327      330       +3     
- Partials       83       85       +2     
Impacted Files Coverage Δ
locust/main.py 22.77% <0.00%> (ø)
locust/stats.py 88.70% <100.00%> (-0.03%) ⬇️
locust/web.py 88.73% <100.00%> (-0.61%) ⬇️
locust/contrib/fasthttp.py 87.70% <0.00%> (-1.07%) ⬇️
locust/runners.py 78.68% <0.00%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b72b9b...eccca55. Read the comment docs.

@heyman heyman mentioned this pull request Apr 7, 2020
@cyberw
Copy link
Collaborator

cyberw commented Apr 7, 2020

LGTM!

@heyman heyman merged commit aa16edc into master Apr 7, 2020
@heyman heyman deleted the csv-stats-improvements branch April 14, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More information in csv reports
2 participants